openstack/puppet-manila
Code Issues Proposed changes

Deprecate unused parameter

Browse Source 
The manila::share::hitachi_hnas::share_backend_name parameter is not
used.

Change-Id: I2ddd1fb3889d5451ba8cd2d8782d0e28e28a2155
This commit is contained in:
Takashi Kajinami 2022-04-12 09:43:26 +09:00
parent d88d284944
commit 49291198a3
2 changed files with 20 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

23
manifests/share/hitachi_hnas.pp
View File

@ -30,6 +30,8 @@
# managing share servers.
# Defaults to false.
#
# DEPRECAED PARAMETERS
#
# [*share_backend_name*]
# (optional) Name of the backend in manila.conf that
# these settings will reside in
@ -47,16 +49,21 @@
# }
#
class manila::share::hitachi_hnas (
$hitachi_hnas_user,
$hitachi_hnas_password,
$hitachi_hnas_ip,
$hitachi_hnas_evs_id,
$hitachi_hnas_evs_ip,
$hitachi_hnas_file_system_name,
$driver_handles_share_servers = false,
$share_backend_name = $name,
$hitachi_hnas_user,
$hitachi_hnas_password,
$hitachi_hnas_ip,
$hitachi_hnas_evs_id,
$hitachi_hnas_evs_ip,
$hitachi_hnas_file_system_name,
$driver_handles_share_servers = false,
# DEPRECAED PARAMETERS
$share_backend_name = undef,
) {
if $share_backend_name != undef {
warning('The share_backend_name parameter is deprecated and has no effect.')
}
manila::backend::hitachi_hnas { 'DEFAULT':
driver_handles_share_servers => $driver_handles_share_servers,
hitachi_hnas_user => $hitachi_hnas_user,

5
releasenotes/notes/hnas-deprecate-default-share_backend_name-2e320eb43f688127.yaml Normal file
View File

@ -0,0 +1,5 @@
---
features:
- |
The ``manila::share::hitachi_hnas::share_backend_name`` parameter has been
deprecated and has no effect.