openstack/puppet-manila
Code Issues Proposed changes

Support tunable parameters related to periodic tasks

Browse Source 
Change-Id: Iaa35e9700b06fbacd396dcefea1ca8dab16d67d0
This commit is contained in:
Takashi Kajinami 2021-12-06 22:04:48 +09:00
parent 0ba949d60e
commit 87e991229c
3 changed files with 36 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

19
manifests/init.pp
View File

@ -187,6 +187,19 @@
# will be run through a green thread.
# Defaults to $::os_service_default
#
# [*report_interval*]
# (optional) Seconds between nodes reporting state to datastore.
# Defaults to $::os_service_default
#
# [*periodic_interval*]
# (optional) Seconds between running periodic tasks.
# Defaults to $::os_service_default
#
# [*periodic_fuzzy_delay*]
# (optional) Range of seconds to randomly delay when starting the periodic
# task scheduler to reduce stampending.
# Defaults to $::os_service_default.
#
# DEPRECATED PARAMETERS
#
# [*sql_connection*]
@ -265,6 +278,9 @@ class manila (
$amqp_password = $::os_service_default,
$purge_config = false,
$host = $::os_service_default,
$report_interval = $::os_service_default,
$periodic_interval = $::os_service_default,
$periodic_fuzzy_delay = $::os_service_default,
# DEPRECATED PARAMETERS
$database_min_pool_size = undef,
$sql_connection = undef,
@ -384,6 +400,9 @@ removed in a future realse. Use manila::db::database_max_overflow instead')
'DEFAULT/rootwrap_config': value => $rootwrap_config;
'DEFAULT/state_path': value => $state_path;
'DEFAULT/host': value => $host;
'DEFAULT/report_interval': value => $report_interval;
'DEFAULT/periodic_interval': value => $periodic_interval;
'DEFAULT/periodic_fuzzy_delay': value => $periodic_fuzzy_delay;
}
oslo::concurrency { 'manila_config': lock_path => $lock_path }

8
releasenotes/notes/periodic-tunables-e228f296c38202cd.yaml Normal file
View File

@ -0,0 +1,8 @@
---
features:
- |
The following three parameters have been added to the ``manila`` class.
- ``report_interval``
- ``periodic_interval``
- ``periodic_fuzzy_delay``

9
spec/classes/manila_init_spec.rb
View File

@ -66,6 +66,15 @@ describe 'manila' do
is_expected.to contain_manila_config('DEFAULT/host').with(
:value => '<SERVICE DEFAULT>'
)
is_expected.to contain_manila_config('DEFAULT/report_interval').with(
:value => '<SERVICE DEFAULT>'
)
is_expected.to contain_manila_config('DEFAULT/periodic_interval').with(
:value => '<SERVICE DEFAULT>'
)
is_expected.to contain_manila_config('DEFAULT/periodic_fuzzy_delay').with(
:value => '<SERVICE DEFAULT>'
)
is_expected.to contain_manila_config('oslo_concurrency/lock_path').with(
:value => '/tmp/manila/manila_locks'
)