openstack/puppet-manila
Code Issues Proposed changes

Update README to indicate being on Stackforge

Browse Source 
This change updates the reference to Stackforge and also fixes
capitalization of OpenStack in the README. It also fixes a few minor
issues that were failing check tests.

Change-Id: I3bc4fc8515c1b3d56d789f1bb199e2cd512e6dbe
This commit is contained in:
Bob Callaway 2014-09-25 07:02:50 -04:00
parent fb737625d2
commit 944979530e
8 changed files with 13 additions and 14 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
README.md
View File

@ -16,21 +16,21 @@ manila
Overview
--------
The manila module will soon be submitted to [Stackforge](https://github.com/stackforge), an effort by the Openstack infrastructure team to provide continuous integration testing and code review for Openstack and Openstack community projects not part of the core software. The module its self is used to flexibly configure and manage the file system service for Openstack.
The manila module is part of [Stackforge](https://github.com/stackforge), an effort by the OpenStack infrastructure team to provide continuous integration testing and code review for OpenStack and OpenStack community projects not part of the core software. The module its self is used to flexibly configure and manage the file system service for OpenStack.
Module Description
------------------
The manila module is a thorough attempt to make Puppet capable of managing the entirety of manila. This includes manifests to provision such things as keystone endpoints, RPC configurations specific to manila, and database connections.
This module is tested in combination with other modules needed to build and leverage an entire Openstack software stack. These modules can be found, all pulled together in the [openstack module](https://github.com/stackfoge/puppet-openstack).
This module is tested in combination with other modules needed to build and leverage an entire OpenStack software stack. These modules can be found, all pulled together in the [openstack module](https://github.com/stackfoge/puppet-openstack).
Setup
-----
**What the manila module affects**
* manila, the file system service for Openstack.
* manila, the file system service for OpenStack.
### Installing manila
@ -67,4 +67,4 @@ Release Notes
**1.0.0**
* Initial commit
* Initial commit

2
manifests/backend/generic.pp
View File

@ -71,5 +71,5 @@ define manila::backend::generic (
"${name}/service_instance_smb_config_path": value => $service_instance_smb_config_path;
"${name}/share_volume_fstype": value => $share_volume_fstype;
"${name}/share_helpers": value => $share_helpers;
}
}
}

4
manifests/backend/netapp.pp
View File

@ -72,15 +72,13 @@ define manila::backend::netapp (
$netapp_share_driver = 'manila.share.drivers.netapp.cluster_mode.NetAppClusteredShareDriver'
manila_config {
"DEFAULT/enabled_share_backends": value => $share_backend_name;
'DEFAULT/enabled_share_backends': value => $share_backend_name;
"${share_backend_name}/share_backend_name": value => $share_backend_name;
"${share_backend_name}/share_driver": value => $netapp_share_driver;
"${share_backend_name}/netapp_nas_transport_type": value => $netapp_nas_transport_type;
"${share_backend_name}/netapp_nas_login": value => $netapp_nas_login;
"${share_backend_name}/netapp_nas_password": value => $netapp_nas_password, secret => true;
"${share_backend_name}/netapp_nas_server_hostname": value => $netapp_nas_server_hostname;
"${share_backend_name}/netapp_nas_size_multiplier": value => $netapp_nas_size_multiplier;
"${share_backend_name}/netapp_nas_vfiler": value => $netapp_nas_vfiler;
"${share_backend_name}/netapp_nas_volume_name_template": value => $netapp_nas_volume_name_template;
"${share_backend_name}/netapp_vserver_name_template": value => $netapp_vserver_name_template;
"${share_backend_name}/netapp_lif_name_template": value => $netapp_lif_name_template;

2
manifests/init.pp
View File

@ -115,7 +115,7 @@ class manila (
$verbose = false,
$debug = false,
$storage_availability_zone = 'nova',
$rootwrap_config = "/etc/manila/rootwrap.conf",
$rootwrap_config = '/etc/manila/rootwrap.conf',
) {
include manila::params

3
manifests/service_instance.pp
View File

@ -71,6 +71,7 @@
# Defaults to: false
class manila::service_instance (
$share_backend_name = $name,
$service_image_name = 'manila-service-image',
$service_instance_name_template = 'manila_service_instance_%s',
$service_instance_user = undef,
@ -106,5 +107,5 @@ class manila::service_instance (
"${name}/service_network_division_mask": value => $service_network_division_mask;
"${name}/interface_driver": value => $interface_driver;
"${name}/connect_share_server_to_tenant_network": value => $connect_share_server_to_tenant_network;
}
}
}

2
manifests/type_set.pp
View File

@ -38,7 +38,7 @@ define manila::type_set (
$os_region_name = undef,
) {
# TODO: (xarses) This should be moved to a ruby provider so that among other
# reasons, the credential discovery magic can occur like in neutron.

2
spec/classes/manila_backends_spec.rb
View File

@ -39,7 +39,7 @@ describe 'manila::backends' do
context 'configure manila with default parameters' do
before :each do
params.merge!(
:enabled_share_backends => ['lowcost', 'regular', 'premium'],
:enabled_share_backends => ['lowcost', 'regular', 'premium']
)
end

4
spec/classes/manila_keystone_auth_spec.rb
View File

@ -51,7 +51,7 @@ describe 'manila::keystone::auth' do
:admin_protocol => 'https',
:internal_protocol => 'https',
:public_protocol => 'https',
:share_version => 'v42'
:share_version => 'v42'
)
end
@ -68,7 +68,7 @@ describe 'manila::keystone::auth' do
describe 'when endpoint should not be configured' do
let :params do
req_params.merge(
:configure_endpoint => false,
:configure_endpoint => false
)
end
it { should_not contain_keystone_endpoint('RegionOne/manila') }