
Add the ability to use python-pymysql library as backend for MySQL connections. Update acceptance tests to use pyMySQL. Change-Id: Ia47aa99ade73ae63da0e00e32a4f87cefaaa9bda Docs: https://wiki.openstack.org/wiki/PyMySQL_evaluation
115 lines
4.1 KiB
Ruby
115 lines
4.1 KiB
Ruby
require 'spec_helper'
|
|
|
|
describe 'manila::db' do
|
|
|
|
shared_examples 'manila::db' do
|
|
|
|
context 'with default parameters' do
|
|
|
|
it { is_expected.to contain_manila_config('database/connection').with_value('sqlite:////var/lib/manila/manila.sqlite').with_secret(true) }
|
|
it { is_expected.to contain_manila_config('database/idle_timeout').with_value('<SERVICE DEFAULT>') }
|
|
it { is_expected.to contain_manila_config('database/min_pool_size').with_value('<SERVICE DEFAULT>') }
|
|
it { is_expected.to contain_manila_config('database/max_pool_size').with_value('<SERVICE DEFAULT>') }
|
|
it { is_expected.to contain_manila_config('database/max_overflow').with_value('<SERVICE DEFAULT>') }
|
|
it { is_expected.to contain_manila_config('database/max_retries').with_value('<SERVICE DEFAULT>') }
|
|
it { is_expected.to contain_manila_config('database/retry_interval').with_value('<SERVICE DEFAULT>') }
|
|
|
|
end
|
|
|
|
context 'with specific parameters' do
|
|
let :params do
|
|
{ :database_connection => 'mysql+pymysql://manila:manila@localhost/manila',
|
|
:database_idle_timeout => '3601',
|
|
:database_min_pool_size => '2',
|
|
:database_max_pool_size => '21',
|
|
:database_max_retries => '11',
|
|
:database_max_overflow => '21',
|
|
:database_retry_interval => '11', }
|
|
end
|
|
|
|
it { is_expected.to contain_manila_config('database/connection').with_value('mysql+pymysql://manila:manila@localhost/manila').with_secret(true) }
|
|
it { is_expected.to contain_manila_config('database/idle_timeout').with_value('3601') }
|
|
it { is_expected.to contain_manila_config('database/min_pool_size').with_value('2') }
|
|
it { is_expected.to contain_manila_config('database/max_retries').with_value('11') }
|
|
it { is_expected.to contain_manila_config('database/max_pool_size').with_value('21') }
|
|
it { is_expected.to contain_manila_config('database/max_overflow').with_value('21') }
|
|
it { is_expected.to contain_manila_config('database/retry_interval').with_value('11') }
|
|
|
|
end
|
|
|
|
context 'with MySQL-python library as backend package' do
|
|
let :params do
|
|
{ :database_connection => 'mysql://manila:manila@localhost/manila' }
|
|
end
|
|
|
|
it { is_expected.to contain_manila_config('database/connection').with_value('mysql://manila:manila@localhost/manila').with_secret(true) }
|
|
end
|
|
|
|
context 'with postgresql backend' do
|
|
let :params do
|
|
{ :database_connection => 'postgresql://manila:manila@localhost/manila', }
|
|
end
|
|
|
|
it 'install the proper backend package' do
|
|
is_expected.to contain_package('python-psycopg2').with(:ensure => 'present')
|
|
end
|
|
|
|
end
|
|
|
|
context 'with incorrect database_connection string' do
|
|
let :params do
|
|
{ :database_connection => 'redis://manila:manila@localhost/manila', }
|
|
end
|
|
|
|
it_raises 'a Puppet::Error', /validate_re/
|
|
end
|
|
|
|
context 'with incorrect database_connection string' do
|
|
let :params do
|
|
{ :database_connection => 'foo+pymysql://manila:manila@localhost/manila', }
|
|
end
|
|
|
|
it_raises 'a Puppet::Error', /validate_re/
|
|
end
|
|
|
|
end
|
|
|
|
context 'on Debian platforms' do
|
|
let :facts do
|
|
@default_facts.merge({ :osfamily => 'Debian',
|
|
:operatingsystem => 'Debian',
|
|
:operatingsystemrelease => 'jessie',
|
|
})
|
|
end
|
|
|
|
it_configures 'manila::db'
|
|
|
|
context 'using pymysql driver' do
|
|
let :params do
|
|
{ :database_connection => 'mysql+pymysql://manila:manila@localhost/manila' }
|
|
end
|
|
|
|
it { is_expected.to contain_package('manila-backend-package').with({ :ensure => 'present', :name => 'python-pymysql' }) }
|
|
end
|
|
end
|
|
|
|
context 'on Redhat platforms' do
|
|
let :facts do
|
|
@default_facts.merge({ :osfamily => 'RedHat',
|
|
:operatingsystemrelease => '7.1',
|
|
})
|
|
end
|
|
|
|
it_configures 'manila::db'
|
|
|
|
context 'using pymysql driver' do
|
|
let :params do
|
|
{ :database_connection => 'mysql+pymysql://manila:manila@localhost/manila' }
|
|
end
|
|
|
|
it { is_expected.not_to contain_package('manila-backend-package') }
|
|
end
|
|
end
|
|
|
|
end
|