openstack/tempest-lib
Code Issues Proposed changes

Improve unit test coverage for alt_auth data

Browse Source 
Using alternative or empty auth_data is only tested for one
of the auth parts. Extend tests to cover headers, body and url.

Change-Id: I5e11bdb342beb5431f8199391d037018c7f26e9a
This commit is contained in:
Andrea Frittoli (andreaf) 2015-10-16 14:02:38 +01:00
parent ca96243e58
commit 4259393446
1 changed files with 21 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

24
tempest_lib/tests/test_auth.py
View File

@ -198,14 +198,14 @@ class TestKeystoneV2AuthProvider(BaseAuthTestsSetUp):
self.assertIsNone(self.auth_provider.alt_part)
self.assertIsNone(self.auth_provider.alt_auth_data)
def test_request_with_identical_alt_auth(self):
def _test_request_with_identical_alt_auth(self, part):
"""Test alternate but identical auth data for headers
Assert that when the alt data is provided, but it's actually
identical, an exception is raised.
"""
self.auth_provider.set_alt_auth_data(
'headers',
part,
(fake_identity.TOKEN, self._get_fake_identity()))
filters = {
'service': 'compute',
@ -217,6 +217,15 @@ class TestKeystoneV2AuthProvider(BaseAuthTestsSetUp):
self.auth_provider.auth_request,
'GET', self.target_url, filters=filters)
def test_request_with_identical_alt_auth_headers(self):
self._test_request_with_identical_alt_auth('headers')
def test_request_with_identical_alt_auth_url(self):
self._test_request_with_identical_alt_auth('url')
def test_request_with_identical_alt_auth_body(self):
self._test_request_with_identical_alt_auth('body')
def test_request_with_alt_part_without_alt_data(self):
"""Test empty alternate auth data
@ -238,7 +247,7 @@ class TestKeystoneV2AuthProvider(BaseAuthTestsSetUp):
self.assertIsNone(headers)
self.assertEqual(body, None)
def test_request_with_alt_part_without_alt_data_no_change(self):
def _test_request_with_alt_part_without_alt_data_no_change(self, body):
"""Test empty alternate auth data with no effect
Assert that when alt_part is defined, no auth_data is provided,
@ -256,6 +265,15 @@ class TestKeystoneV2AuthProvider(BaseAuthTestsSetUp):
self.auth_provider.auth_request,
'GET', self.target_url, filters=filters)
def test_request_with_alt_part_without_alt_data_no_change_headers(self):
self._test_request_with_alt_part_without_alt_data_no_change('headers')
def test_request_with_alt_part_without_alt_data_no_change_url(self):
self._test_request_with_alt_part_without_alt_data_no_change('url')
def test_request_with_alt_part_without_alt_data_no_change_body(self):
self._test_request_with_alt_part_without_alt_data_no_change('body')
def test_request_with_bad_service(self):
filters = {
'service': 'BAD_SERVICE',