From 9158eb5b2b64dc3523985f2893811633285bd687 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?C=C3=A9dric=20Jeanneret?= Date: Wed, 8 Apr 2020 11:02:28 +0200 Subject: [PATCH] Ensure we get a sorted list for validation groups Change-Id: I3f905af3424fd25cd7dc71743ef8179cf4723bcd --- validations_libs/group.py | 2 +- validations_libs/tests/test_group.py | 2 +- validations_libs/tests/test_utils.py | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/validations_libs/group.py b/validations_libs/group.py index 89daf17d..c3c1f615 100644 --- a/validations_libs/group.py +++ b/validations_libs/group.py @@ -42,4 +42,4 @@ class Group(object): @property def get_groups_keys_list(self): - return [gp for gp in self.data.keys()] + return [gp for gp in sorted(self.data.keys())] diff --git a/validations_libs/tests/test_group.py b/validations_libs/tests/test_group.py index dac8f904..ae36c006 100644 --- a/validations_libs/tests/test_group.py +++ b/validations_libs/tests/test_group.py @@ -47,7 +47,7 @@ class TestGroup(TestCase): @mock.patch('six.moves.builtins.open') def test_get_groups_keys_list(self, mock_open, mock_yaml): grp = Group('/tmp/foo') - ret = ['no-op', 'pre', 'post'] + ret = ['no-op', 'post', 'pre'] data = grp.get_groups_keys_list self.assertEquals(data, ret) diff --git a/validations_libs/tests/test_utils.py b/validations_libs/tests/test_utils.py index df997f20..e8e00677 100644 --- a/validations_libs/tests/test_utils.py +++ b/validations_libs/tests/test_utils.py @@ -118,7 +118,7 @@ class TestUtils(TestCase): def test_get_validation_group_name_list(self, mock_open, mock_load): result = utils.get_validation_group_name_list('/foo/groups.yaml') - self.assertEqual(result, ['no-op', 'pre', 'post']) + self.assertEqual(result, ['no-op', 'post', 'pre']) @mock.patch('validations_libs.utils.parse_all_validations_on_disk', return_value=[fakes.FAKE_METADATA])