Fix reraising of exceptions

Exceptions should be reraised with just "raise" and not "raise e" to
preserve the traceback. This also addresses a couple cases where the
catching and reraising of the exception was not actually doing anything.

Change-Id: I94ba193f728ee7ca6f689f70fc08317a1dd50c92
Signed-off-by: Sean McGinnis <sean.mcginnis@gmail.com>

watcher/applier/actions/base.py

@@ -131,11 +131,8 @@ class BaseAction(loadable.Loadable):
         raise NotImplementedError()
 
     def validate_parameters(self):
-        try:
-            jsonschema.validate(self.input_parameters, self.schema)
-            return True
-        except jsonschema.ValidationError as e:
-            raise e
+        jsonschema.validate(self.input_parameters, self.schema)
+        return True
 
     @abc.abstractmethod
     def get_description(self):

watcher/applier/actions/volume_migration.py

@@ -109,11 +109,8 @@ class VolumeMigrate(base.BaseAction):
         }
 
     def validate_parameters(self):
-        try:
-            jsonschema.validate(self.input_parameters, self.schema)
-            return True
-        except jsonschema.ValidationError as e:
-            raise e
+        jsonschema.validate(self.input_parameters, self.schema)
+        return True
 
     @property
     def volume_id(self):

watcher/decision_engine/goal/efficacy/indicators.py

@@ -59,7 +59,7 @@ class IndicatorSpecification(object):
             jsonschema.validate(value, cls.schema)
         except (SchemaError, ValidationError) as exc:
             LOG.exception(exc)
-            raise exc
+            raise
         except Exception as exc:
             LOG.exception(exc)
             raise exception.InvalidIndicatorValue(