openstack/zun
Code Issues Proposed changes

Change default scheduler to filter_scheduler

Browse Source 
The current default is chance_scheduler which simply randomly
pick a host. As filter_scheduler is available, it is time to
switch the default to filter_scheduler.

Change-Id: I0ff1fd866de593716385df919cdf1ddf510c0512
This commit is contained in:
Hongbin Lu 2017-06-01 23:21:50 +00:00
parent b0057b30d6
commit 5ef6454235
2 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
zun/conf/scheduler.py
View File

@ -21,7 +21,7 @@ scheduler_group = cfg.OptGroup(name="scheduler",
scheduler_opts = [ scheduler_opts = [
cfg.StrOpt("driver", cfg.StrOpt("driver",
default="chance_scheduler", default="filter_scheduler",
choices=("chance_scheduler", "fake_scheduler", choices=("chance_scheduler", "fake_scheduler",
"filter_scheduler"), "filter_scheduler"),
help=""" help="""

6
zun/tests/unit/scheduler/test_client.py
View File

@ -14,8 +14,8 @@ import mock
from oslo_config import cfg from oslo_config import cfg
from zun.scheduler import chance_scheduler
from zun.scheduler import client as scheduler_client from zun.scheduler import client as scheduler_client
from zun.scheduler import filter_scheduler
from zun.tests import base from zun.tests import base
from zun.tests.unit.scheduler import fake_scheduler from zun.tests.unit.scheduler import fake_scheduler
@ -32,14 +32,14 @@ class SchedulerClientTestCase(base.TestCase):
def test_init_using_default_schedulerdriver(self): def test_init_using_default_schedulerdriver(self):
driver = self.client_cls().driver driver = self.client_cls().driver
self.assertIsInstance(driver, chance_scheduler.ChanceScheduler) self.assertIsInstance(driver, filter_scheduler.FilterScheduler)
def test_init_using_custom_schedulerdriver(self): def test_init_using_custom_schedulerdriver(self):
CONF.set_override('driver', 'fake_scheduler', group='scheduler') CONF.set_override('driver', 'fake_scheduler', group='scheduler')
driver = self.client_cls().driver driver = self.client_cls().driver
self.assertIsInstance(driver, fake_scheduler.FakeScheduler) self.assertIsInstance(driver, fake_scheduler.FakeScheduler)
@mock.patch('zun.scheduler.chance_scheduler.ChanceScheduler' @mock.patch('zun.scheduler.filter_scheduler.FilterScheduler'
'.select_destinations') '.select_destinations')
def test_select_destinations(self, mock_select_destinations): def test_select_destinations(self, mock_select_destinations):
fake_args = ['ctxt', 'fake_containers'] fake_args = ['ctxt', 'fake_containers']