zun/HACKING.rst
Feng Shengqin 340894ae84 Remove duplicated hacking rule Z318
Change-Id: I143892498b4c375c1c6a53000f81251d3c04a1b9
Closes-Bug: #1696466
2017-06-08 11:07:26 +08:00

23 lines
969 B
ReStructuredText

Zun Style Commandments
======================
Read the OpenStack Style Commandments https://docs.openstack.org/developer/hacking/
Zun Specific Commandments
-------------------------
- [Z302] Change assertEqual(A is not None) by optimal assert like
assertIsNotNone(A).
- [Z310] timeutils.utcnow() wrapper must be used instead of direct calls to
datetime.datetime.utcnow() to make it easy to override its return value.
- [Z316] Change assertTrue(isinstance(A, B)) by optimal assert like
assertIsInstance(A, B).
- [Z322] Method's default argument shouldn't be mutable.
- [Z323] Change assertEqual(True, A) or assertEqual(False, A) by optimal assert
like assertTrue(A) or assertFalse(A)
- [Z336] Must use a dict comprehension instead of a dict constructor
with a sequence of key-value pairs.
- [Z338] Use assertIn/NotIn(A, B) rather than assertEqual(A in B, True/False).
- [Z339] Don't use xrange()
- [Z352] LOG.warn is deprecated. Enforce use of LOG.warning.