recordsansible/ara-clients
Code Issues Proposed changes

Fix usage of GET requests with query parameters

Browse Source 
Python requests accepts GET query parameters (?foo=bar&bar=foo) inside
the "params" key of the request.

Change-Id: Ia493819c48ec907bb6fb9454dea95e4fe62ef03a
This commit is contained in:
David Moreau Simard 2018-12-18 11:28:46 -05:00
parent 6597aff444
commit 051c4c92de
No known key found for this signature in database
GPG Key ID: CBEB466764A9E621
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
ara/clients/http.py
View File

@ -50,7 +50,7 @@ class HttpClient(object):
def get(self, url, **payload):
if payload:
return self._request("get", url, params=json.dumps(payload))
return self._request("get", url, **payload)
else:
return self._request("get", url)
@ -93,7 +93,7 @@ class AraHttpClient(object):
return response.json()
def get(self, endpoint, **kwargs):
return self._request("get", endpoint, **kwargs)
return self._request("get", endpoint, params=kwargs)
def patch(self, endpoint, **kwargs):
return self._request("patch", endpoint, **kwargs)