recordsansible/ara-clients
Code Issues Proposed changes

Use an if/else for returning the client in get_client

Browse Source 
Attempting to do something more fancy lead the method to instanciate
both clients, let's not do that.

Change-Id: I0c8abc48ce146fe7dec592779b4cd07dedcc3bd8
This commit is contained in:
David Moreau Simard 2019-01-22 09:26:46 -05:00
parent 4a3f2b4418
commit bb45af0f98
No known key found for this signature in database
GPG Key ID: CBEB466764A9E621
1 changed files with 5 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
ara/clients/utils.py
View File

@ -23,12 +23,9 @@ def get_client(client="offline", endpoint="http://127.0.0.1:8000", timeout=30):
""" """
Returns a specified client configuration or one with sane defaults. Returns a specified client configuration or one with sane defaults.
""" """
try: if client == "offline":
# fmt: off return AraOfflineClient()
return { elif client == "http":
"offline": AraOfflineClient(), return AraHttpClient(endpoint=endpoint, timeout=timeout)
"http": AraHttpClient(endpoint=endpoint, timeout=timeout) else:
}[client]
# fmt: on
except KeyError:
raise ValueError(f"Unsupported API client: {client} (use 'http' or 'offline')") raise ValueError(f"Unsupported API client: {client} (use 'http' or 'offline')")