starlingx/docs
Code Issues Proposed changes

Merge "Add wording to ease on patch review requirements"

Browse Source
This commit is contained in:
Zuul 2024-09-11 19:06:52 +00:00 committed by Gerrit Code Review
commit 61174678f1
1 changed files with 11 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
doc/source/developer_resources/code-submission-guide.rst
View File

@ -91,6 +91,17 @@ Code reviews
* In order for code to get merged, two core reviewers must give the review +2.
A final Workflow +1 from one core reviewer will allow the code to merge.
Typically, the final W+1 is done by the second core reviewer.
* While the requirement to have at least 2 ‘+2’ votes from core reviewers is set
to advocate for higher code quality through a more diverse set of eyes, in certain
cases it can also become a bottleneck. When the core team of a sub-project
becomes too small to be able to sustain the 2 ‘+2’ rule, they can reduce the
requirement to 1, however, a core reviewer should not approve their own changes,
when that is possible.
* In the above case it is further advised to seek for a higher number of ‘+1’
votes. This can ensure the changes are still thoroughly reviewed, while can also
help with increasing the number of core reviewers with a more engaged team.
* If a core reviewer sets a -2, the code cannot be merged until that reviewer
removes their -2.
* Authors should not review their own code and, therefore, should not +2 or W+