Change to ansible become

Change-Id: Ieb151dd90af36ef037c4d705632b61f04d16a768

ansible/browbeat/group_vars/all

@@ -1,2 +1,2 @@
 ---
-ansible_sudo: yes
+ansible_become: true

ansible/check/group_vars/ceph

@@ -1,3 +1,3 @@
 ---
-ansible_sudo: yes
+ansible_become: true
 tuned_profile: throughput-performance

ansible/check/group_vars/compute

@@ -1,5 +1,5 @@
 ---
-ansible_sudo: yes
+ansible_become: true
 reserved_host_memory_check: 2048
 tuned_profile: virtual-host
 nova_vif_timeout: 300

ansible/check/group_vars/controller

@@ -1,5 +1,5 @@
 ---
-ansible_sudo: yes
+ansible_become: true
 tuned_profile: throughput-performance
 rabbitmq_fd: 1600
 haproxy_max_connections: 4096

ansible/check/site.yml

@@ -28,8 +28,7 @@
 - hosts: localhost
   gather_facts: False
   become: false
-  sudo: false
   name: Generating bug report
   tasks:
     - local_action: template src=templates/bug_report.j2 dest=./bug_report.log
-      sudo: false
+      become: false

ansible/install/connmon.yml

@@ -6,7 +6,7 @@
 - hosts: undercloud
   remote_user: stack
   vars:
-    ansible_sudo: true
+    ansible_become: true
     undercloud: true
   roles:
   - common
@@ -15,7 +15,7 @@
 - hosts: controller
   remote_user: heat-admin
   vars:
-    ansible_sudo: true
+    ansible_become: true
     undercloud: false
   roles:
   - common

ansible/install/pbench.yml

@@ -7,7 +7,7 @@
   remote_user: stack
   gather_facts: false
   vars:
-    ansible_sudo: true
+    ansible_become: true
     undercloud: true
   roles:
   - common
@@ -17,7 +17,7 @@
   remote_user: heat-admin
   gather_facts: false
   vars:
-    ansible_sudo: true
+    ansible_become: true
     undercloud: false
     undercloud_root_ssh_key: "{{ lookup('file', 'roles/pbench/files/undercloud_root_id_rsa.pub') }}"
     undercloud_stack_ssh_key: "{{ lookup('file', 'roles/pbench/files/undercloud_stack_id_rsa.pub') }}"

ansible/install/roles/browbeat/tasks/main.yml

@@ -11,7 +11,7 @@
     - libpng-devel
 
 - name: Install pip
-  become: yes
+  become: true
   easy_install: name=pip
 
 - name: Install virtualenv
@@ -56,9 +56,17 @@
   ignore_errors: true
   changed_when: false
 
-- name: Upload cirros image into cloud
+- name: Upload cirros image into cloud (OSP8)
   shell: . /home/stack/overcloudrc; glance image-create --name cirros --visibility public --disk-format=qcow2 --container-format=bare < /home/stack/cirros.img
   when: "'cirros' not in '{{ cirros_image_exists.stdout }}'"
+  register: cirros_image_osp8
+  ignore_errors: true
+
+- name: Upload cirros image into cloud (OSP7)
+  shell: . /home/stack/overcloudrc; glance image-create --name cirros --is-public true --disk-format=qcow2 --container-format=bare < /home/stack/cirros.img
+  when: "'cirros' not in '{{ cirros_image_exists.stdout }}' and not cirros_image_osp8.rc == 0"
+  ignore_errors: true
+
 
 - name: Fetch centos7 image
   get_url: url={{ centos_image_url }} dest=/home/stack/centos7.qcow2
@@ -69,6 +77,13 @@
   ignore_errors: true
   changed_when: false
 
-- name: Upload centos7 image into cloud
+- name: Upload centos7 image into cloud (OSP8)
   shell: . /home/stack/overcloudrc; glance image-create --name centos7 --visibility public --disk-format=qcow2 --container-format=bare < /home/stack/centos7.qcow2
   when: "'centos7' not in '{{ centos7_image_exists.stdout }}'"
+  register: centos7_image_osp8
+  ignore_errors: true
+
+- name: Upload centos7 image into cloud (OSP7)
+  shell: . /home/stack/overcloudrc; glance image-create --name centos7 --is-public true --disk-format=qcow2 --container-format=bare < /home/stack/centos7.qcow2
+  when: "'centos7' not in '{{ centos7_image_exists.stdout }}' and not centos7_image_osp8.rc == 0"
+  ignore_errors: true

ansible/install/shaker.yml

@@ -6,7 +6,7 @@
 - hosts: undercloud
   remote_user: stack
   vars:
-    ansible_sudo: true
+    ansible_become: true
   roles:
   - common
   - shaker