From 28fc5d375fbf13ac6d102acc71de2eb3eeb29d1c Mon Sep 17 00:00:00 2001
From: Ramana Raja <rraja@redhat.com>
Date: Mon, 7 Dec 2015 12:15:09 +0530
Subject: [PATCH] Restrict scope of loop control variables to local
Some of the loop control variables are global. This as expected has
lead to corruption of their values, and produced undesired results.
Fix this issue by setting the scope of these variables to local.
Closes Bug: #1523348
Change-Id: I0f5676c5a0b97d3e027a1e7677b4b5a21470913b
---
devstack/gluster-functions.sh | 3 +++
1 file changed, 3 insertions(+)
diff --git a/devstack/gluster-functions.sh b/devstack/gluster-functions.sh
index 465d244..7edb7ee 100755
--- a/devstack/gluster-functions.sh
+++ b/devstack/gluster-functions.sh
@@ -75,6 +75,7 @@ function _delete_gluster_shares {
gluster_volumes+=,$(echo $share | cut -d/ -f2);
done
+ local vol_name
for vol_name in $(echo $gluster_volumes | sed "s/,/ /g"); do
sudo gluster --mode=script volume stop $vol_name
sudo gluster --mode=script volume delete $vol_name
@@ -226,6 +227,7 @@ function _create_thin_lv_gluster_vol {
# Format the LV.
local mkfs_result=0
+ local i
for i in `seq 100`; do
mkfs_result=0
sudo mkfs.xfs -i size=512 /dev/$GLUSTERFS_VG_NAME/$vol_name || mkfs_result=$?
@@ -320,6 +322,7 @@ function _configure_manila_glusterfs_native {
# Create four GlusterFS volumes to be used as shares.
_create_thin_lv_pool
+ local i
for i in `seq 1 20`; do
_create_thin_lv_gluster_vol manila-glusterfs-native-vol-20G-$i 20G
# Configure the volume to use GlusterFS's TLS support required by the