change unit test case for vm.py
Need to change unit test case for vm.py. We need to use zhmcclient_mock framework to write unit testcase. closes-Bug: 1670667 Change-Id: Id8e743bd0602816af98559da6b67a52926e56262 Signed-off-by: Prabhat Ranjan <pranjank@in.ibm.com>
This commit is contained in:
Prabhat Ranjan
parent
072650a217
commit
c8d33369cd
@ -12,10 +12,41 @@
|
||||
# See the License for the specific language governing permissions and
|
||||
# limitations under the License.
|
||||
|
||||
import requests.packages.urllib3
|
||||
import zhmcclient
|
||||
import zhmcclient_mock
|
||||
|
||||
from nova.objects import flavor as flavor_obj
|
||||
from nova.objects import instance as instance_obj
|
||||
from nova.test import TestCase
|
||||
from nova_dpm.virt.dpm import exceptions
|
||||
from nova_dpm.virt.dpm import vm
|
||||
|
||||
|
||||
def fake_session():
|
||||
session = zhmcclient_mock.FakedSession(
|
||||
'fake-host', 'fake-hmc', '2.13.1', '1.8')
|
||||
|
||||
cpc1 = session.hmc.cpcs.add({
|
||||
'name': 'cpc_1',
|
||||
'description': 'CPC #1',
|
||||
'dpm-enabled': True,
|
||||
'processor-count-ifl': 10,
|
||||
'storage-customer': 2048,
|
||||
})
|
||||
adapter1 = cpc1.adapters.add({
|
||||
'object-id': '6511ee0f-0d64-4392-b9e0-cdbea10a17c3',
|
||||
'name': 'fcp_1',
|
||||
'description': 'FCP #1',
|
||||
'type': 'fcp',
|
||||
})
|
||||
adapter1.ports.add({
|
||||
'name': 'fcp_1_1',
|
||||
'description': 'FCP #1 Port #1',
|
||||
})
|
||||
return session
|
||||
|
||||
|
||||
class ValidPartitionNameTestCase(TestCase):
|
||||
|
||||
def setUp(self):
|
||||
@ -49,3 +80,207 @@ class ValidPartitionNameTestCase(TestCase):
|
||||
# See at last instead of 12 character it is 13 character.
|
||||
name5 = 'OpenStack-foo-6511ee0f-0d64-4392-b9e0-cdbea10a17c31'
|
||||
self.assertFalse(vm.is_valid_partition_name(name5))
|
||||
|
||||
|
||||
class VmPartitionInstanceTestCase(TestCase):
|
||||
def setUp(self):
|
||||
super(VmPartitionInstanceTestCase, self).setUp()
|
||||
requests.packages.urllib3.disable_warnings()
|
||||
|
||||
self.session = fake_session()
|
||||
self.client = zhmcclient.Client(self.session)
|
||||
self.cpc = self.client.cpcs.find(**{"name": "cpc_1"})
|
||||
self.flags(host="foo")
|
||||
self.instance = instance_obj.Instance()
|
||||
self.instance.uuid = '6511ee0f-0d64-4392-b9e0-aaaaaaaaaaaa'
|
||||
self.flavor = flavor_obj.Flavor()
|
||||
self.flavor.vcpus = 1
|
||||
self.flavor.memory_mb = 512
|
||||
self.part_name = "OpenStack-foo-" + self.instance.uuid
|
||||
self.part_description = 'OpenStack CPCSubset=foo'
|
||||
|
||||
self.create_partition_properties = {
|
||||
'name': self.part_name,
|
||||
'description': self.part_description}
|
||||
# Create partition in a cpc not from openstack
|
||||
# and used same uuid of instance to create
|
||||
# vm.PartitionInstance class instance except create_partition.
|
||||
partition = self.cpc.partitions.create(
|
||||
self.create_partition_properties)
|
||||
|
||||
adapter = self.cpc.adapters.find(**{'name': 'fcp_1'})
|
||||
self.adapter_object_id = adapter.get_property('object-id')
|
||||
self.port_element_id = adapter.ports.list()[0].get_property(
|
||||
'element-id')
|
||||
storage = self.adapter_object_id + ":" + self.port_element_id
|
||||
self.flags(group="dpm", physical_storage_adapter_mappings=[storage])
|
||||
dpm_hba_dict = {
|
||||
"name": "OpenStack_Port_" + self.adapter_object_id +
|
||||
"_" + str(self.port_element_id),
|
||||
"description": "OpenStack CPCSubset= foo",
|
||||
"adapter-port-uri": "/api/adapters/"
|
||||
+ self.adapter_object_id +
|
||||
"/storage-ports/" +
|
||||
str(self.port_element_id)
|
||||
}
|
||||
# create hba in cpc.partition not from openstack
|
||||
# and later used to test all function which is related
|
||||
# to hbas except hba_create
|
||||
partition.hbas.create(dpm_hba_dict)
|
||||
self.partition_inst = vm.PartitionInstance(
|
||||
self.instance, self.cpc, self.flavor)
|
||||
|
||||
def test_properties(self):
|
||||
properties = self.partition_inst.properties()
|
||||
self.assertEqual(self.part_name, properties['name'])
|
||||
self.assertEqual(self.part_description, properties['description'])
|
||||
self.assertEqual(1, properties['ifl-processors'])
|
||||
self.assertEqual(512, properties['initial-memory'])
|
||||
self.assertEqual(512, properties['maximum-memory'])
|
||||
|
||||
def test_partition_create(self):
|
||||
partition_name = ('OpenStack-foo-'
|
||||
+ '6511ee0f-0d64-4392-b9e0-bbbbbbbbbbbb')
|
||||
properties = {
|
||||
'name': partition_name,
|
||||
'description': self.part_description,
|
||||
'ifl-processors': self.flavor.vcpus,
|
||||
'initial-memory': self.flavor.memory_mb,
|
||||
'maximum-memory': self.flavor.memory_mb}
|
||||
|
||||
self.partition_inst.create(properties)
|
||||
partition = self.cpc.partitions.find(**{"name": partition_name})
|
||||
self.assertEqual(partition_name, partition.get_property('name'))
|
||||
|
||||
def test_partition_name(self):
|
||||
self.assertEqual(
|
||||
self.part_name,
|
||||
self.partition_inst.partition_name)
|
||||
|
||||
def test_partition_description(self):
|
||||
self.assertEqual(
|
||||
self.part_description,
|
||||
self.partition_inst.partition_description)
|
||||
|
||||
def test_get_partition(self):
|
||||
self.assertEqual(
|
||||
self.part_name,
|
||||
self.partition_inst.get_partition().get_property('name'))
|
||||
|
||||
def test_attach_nic(self):
|
||||
vif = {
|
||||
"details":
|
||||
{"port_filter": False,
|
||||
"object_id": "3ea09d2a-b18d-11e6-89a4-42f2e9ef1641"},
|
||||
"address": "fa:16:3e:e4:9a:98",
|
||||
"type": "dpm_vswitch",
|
||||
"id": "703da361-9d4d-4441-b99b-e081c3e9cfbb"}
|
||||
|
||||
nic_interface = self.partition_inst.attach_nic(vif)
|
||||
self.assertEqual(
|
||||
'OpenStack_Port_703da361-9d4d-4441-b99b-e081c3e9cfbb',
|
||||
nic_interface.properties['name'])
|
||||
|
||||
def test_attach_nic_with_non_dpm_vswitch(self):
|
||||
vif = {
|
||||
"details":
|
||||
{"port_filter": False,
|
||||
"object_id": "3ea09d2a-b18d-11e6-89a4-42f2e9ef1641"},
|
||||
"address": "fa:16:3e:e4:9a:98",
|
||||
"type": "non_dpm_vswitch",
|
||||
"id": "703da361-9d4d-4441-b99b-e081c3e9cfbb"}
|
||||
|
||||
self.assertRaises(
|
||||
Exception,
|
||||
self.partition_inst.attach_nic, vif)
|
||||
|
||||
def test_set_boot_os_specific_parameters(self):
|
||||
data = '1800,0,fa163ee49a98;'
|
||||
self.partition_inst.set_boot_os_specific_parameters(data)
|
||||
self.assertEqual(
|
||||
data,
|
||||
self.partition_inst.get_partition().get_property(
|
||||
'boot-os-specific-parameters'))
|
||||
|
||||
def test_set_boot_os_specific_parameters_negative(self):
|
||||
data = 257 * 'a'
|
||||
self.assertRaises(
|
||||
exceptions.BootOsSpecificParametersPropertyExceededError,
|
||||
self.partition_inst.set_boot_os_specific_parameters, data)
|
||||
|
||||
def test_set_boot_properties(self):
|
||||
|
||||
wwpn = '500507680B214AC1'
|
||||
lun = 1
|
||||
booturi = '/api/partitions/1/hbas/1'
|
||||
partition = self.cpc.partitions.find(**{"name": self.part_name})
|
||||
self.partition_inst.set_boot_properties(wwpn, lun, booturi)
|
||||
self.assertEqual(
|
||||
'storage-adapter',
|
||||
partition.get_property('boot-device'))
|
||||
self.assertEqual(
|
||||
wwpn,
|
||||
partition.get_property('boot-world-wide-port-name'))
|
||||
self.assertEqual(
|
||||
lun,
|
||||
partition.get_property('boot-logical-unit-number'))
|
||||
self.assertEqual(
|
||||
booturi,
|
||||
partition.get_property('boot-storage-device'))
|
||||
|
||||
def test_attach_hbas(self):
|
||||
partition = self.cpc.partitions.find(**{"name": self.part_name})
|
||||
total_hbas = len(partition.hbas.list())
|
||||
self.partition_inst.attach_hbas()
|
||||
self.assertEqual(
|
||||
total_hbas + 1,
|
||||
len(partition.hbas.list()))
|
||||
|
||||
def test_get_adapter_port_mappings(self):
|
||||
adapter_port_map = self.partition_inst.get_adapter_port_mappings()
|
||||
adapter_port = adapter_port_map.get_adapter_port_mapping()[0]
|
||||
self.assertEqual(self.adapter_object_id, adapter_port['adapter_id'])
|
||||
self.assertEqual(self.port_element_id, str(adapter_port['port']))
|
||||
|
||||
def test_get_hba_uri(self):
|
||||
partition = self.cpc.partitions.find(**{"name": self.part_name})
|
||||
self.assertEqual(
|
||||
partition.get_property(
|
||||
'object-uri') + '/hbas/1',
|
||||
self.partition_inst.get_hba_uris()[0])
|
||||
|
||||
def test_get_boot_hba_uri(self):
|
||||
partition = self.cpc.partitions.find(**{"name": self.part_name})
|
||||
self.assertEqual(
|
||||
partition.get_property(
|
||||
'object-uri') + '/hbas/1',
|
||||
self.partition_inst.get_boot_hba_uri())
|
||||
|
||||
|
||||
class PhysicalAdapterModelTestCase(TestCase):
|
||||
|
||||
def setUp(self):
|
||||
super(PhysicalAdapterModelTestCase, self).setUp()
|
||||
requests.packages.urllib3.disable_warnings()
|
||||
self.session = fake_session()
|
||||
self.client = zhmcclient.Client(self.session)
|
||||
self.cpc = self.client.cpcs.find(**{"name": "cpc_1"})
|
||||
self.flags(host="foo")
|
||||
self.fcp_adapter = self.cpc.adapters.find(**{'name': 'fcp_1'})
|
||||
self.phycal_adapter = vm.PhysicalAdapterModel(self.cpc)
|
||||
|
||||
def test_get_adapter(self):
|
||||
adapter_id = self.fcp_adapter.get_property('object-id')
|
||||
adapter = self.phycal_adapter._get_adapter(adapter_id)
|
||||
self.assertEqual(adapter_id, adapter.get_property('object-id'))
|
||||
|
||||
def test_add_adapter_por(self):
|
||||
adapter_id = self.fcp_adapter.get_property('object-id')
|
||||
port = self.fcp_adapter.ports.find(**{'name': 'fcp_1_1'})
|
||||
self.phycal_adapter._add_adapter_port(adapter_id, port)
|
||||
self.assertEqual(
|
||||
adapter_id,
|
||||
self.phycal_adapter._adapter_ports[0]['adapter_id'])
|
||||
self.assertEqual(
|
||||
port,
|
||||
self.phycal_adapter._adapter_ports[0]['port'])
|
||||
|
||||
5
tox.ini
5
tox.ini
@ -39,9 +39,10 @@ commands = oslo_debug_helper {posargs}
|
||||
|
||||
[flake8]
|
||||
# E123, E125 skipped as they are invalid PEP-8.
|
||||
|
||||
# H202: assertRaises Exception too broad (Removed this pep8 exception)
|
||||
# Failing unit test case when we use self.assertRaises(Exception, func). So ignored H202
|
||||
show-source = True
|
||||
ignore = E123,E125
|
||||
ignore = E123,E125,H202
|
||||
builtins = _
|
||||
exclude=.venv,.git,.tox,dist,doc,*lib/python*,*egg,build,.tmp,releasenotes
|
||||
|
||||
|
||||
Loading…
x
Reference in New Issue
Block a user