3a612efd53
This commit is a whole new version of OSPurge. Currently OSPurge suffers from the following limitations: * It's slow (monothread) * It's not guaranteed to complete. If a resource fails to be deleted then OSPurge can choke on deleting other resources that depends on the first one. * Not properly unit tested. * Not modular (one huge file to deal with all services) This new version is: * Faster (multithreaded, thanks to a ThreadPoolExecutor) * Safe (we check and wait for some prerequisites before attempting a delete) * 100% unit tested. * Modular (one file per service) Note that it's Python3.5 compatible. It also uses OpenStack Shade and OpenStack client-config libraries so that OSPurge focuses on the cleaning logic only. Overall I believe this is a better version of OSPurge and more future proof. NOte that we tagged and released OSPurge 1.3 recently in case the new version was not satisfactory to everybody. Change-Id: I5eb92a0556df210ea3cb4e471b8db3b5bf7ed5ee
54 lines
1.8 KiB
Python
54 lines
1.8 KiB
Python
# Licensed under the Apache License, Version 2.0 (the "License"); you may
|
|
# not use this file except in compliance with the License. You may obtain
|
|
# a copy of the License at
|
|
#
|
|
# http://www.apache.org/licenses/LICENSE-2.0
|
|
#
|
|
# Unless required by applicable law or agreed to in writing, software
|
|
# distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
|
|
# WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
|
|
# License for the specific language governing permissions and limitations
|
|
# under the License.
|
|
from typing import Any
|
|
from typing import Dict
|
|
from typing import Iterable
|
|
|
|
from ospurge.resources import base
|
|
from ospurge.resources.base import BaseServiceResource
|
|
|
|
|
|
class ListImagesMixin(BaseServiceResource):
|
|
def list_images_by_owner(self) -> Iterable[Dict[str, Any]]:
|
|
images = []
|
|
for image in self.cloud.list_images():
|
|
if image['owner'] != self.cleanup_project_id:
|
|
continue
|
|
|
|
is_public = image.get('is_public', False)
|
|
visibility = image.get('visibility', "")
|
|
if is_public is True or visibility == 'public':
|
|
if self.options.delete_shared_resources is False:
|
|
continue
|
|
|
|
images.append(image)
|
|
|
|
return images
|
|
|
|
|
|
class Images(base.ServiceResource, ListImagesMixin):
|
|
ORDER = 53
|
|
|
|
def list(self) -> Iterable:
|
|
return self.list_images_by_owner()
|
|
|
|
def should_delete(self, resource: Dict[str, Any]) -> bool:
|
|
return resource['owner'] == self.cleanup_project_id
|
|
|
|
def delete(self, resource: Dict[str, Any]) -> None:
|
|
self.cloud.delete_image(resource['id'])
|
|
|
|
@staticmethod
|
|
def to_str(resource: Dict[str, Any]) -> str:
|
|
return "Image (id='{}', name='{}')".format(
|
|
resource['id'], resource['name'])
|