x/puppet-setproxy
Code Issues Proposed changes

Required options should be required

Browse Source 
Fail the catalog if they are not provided

Change-Id: I7927d78491638d831d33581080f3a76dfdb9fba4
This commit is contained in:
Spencer Krum 2015-04-08 16:03:52 -07:00
parent caaf33a92f
commit d5dc9e2612
2 changed files with 4 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
manifests/gem.pp
View File

@ -16,8 +16,8 @@
# #
# A class to manage rubygems proxy settings # A class to manage rubygems proxy settings
class setproxy::gem ( class setproxy::gem (
$http_proxy = undef, $http_proxy,
$https_proxy = undef, $https_proxy,
) { ) {
file { '/etc/gemrc': file { '/etc/gemrc':

2
manifests/git.pp
View File

@ -35,6 +35,8 @@ class setproxy::git (
} }
if $enable_gitproxy { if $enable_gitproxy {
validate_string($http_proxy)
validate_string($https_proxy)
file { '/usr/local/bin/gitproxy': file { '/usr/local/bin/gitproxy':
ensure => file, ensure => file,
content => template('setproxy/gitproxy.erb'), content => template('setproxy/gitproxy.erb'),