From 59a3e11c1b891c9f582bd7cecdafaa32b61cda31 Mon Sep 17 00:00:00 2001
From: Uggla <uggla@free.fr>
Date: Sat, 9 Jan 2016 19:03:33 +0100
Subject: [PATCH] Finalise new EthernetInterfaces functions

- Add get_mac, get_fqdn, get_ipv4, get_ipv6.
---
 redfish/types.py | 48 ++++++++++++++++++++++++++++++++++++------------
 1 file changed, 36 insertions(+), 12 deletions(-)

diff --git a/redfish/types.py b/redfish/types.py
index 2b064b7..a4075e6 100644
--- a/redfish/types.py
+++ b/redfish/types.py
@@ -456,16 +456,40 @@ class EthernetInterfaces(Base):
         except AttributeError:
             return "Not available"
         
-#===============================================================================
-#     def get_ipv4(self):
-#         '''Get EthernetInterface ipv4 address
-# 
-#         :returns:  list -- interface ip addresses or "Not available"
-# 
-#         '''
-#         try:
-#             return self.data.IPv4Addresses
-#         except AttributeError:
-#             return "Not available"
-#===============================================================================
+
+    def get_ipv4(self):
+        '''Get EthernetInterface ipv4 address
+ 
+        :returns:  list -- interface ip addresses or "Not available"
+ 
+        '''
+        
+        ipaddresses = []
+        
+        try:
+            for ip_settings in self.data.IPv4Addresses:
+                address = ip_settings['Address']
+                ipaddresses.append(address)
+            
+            return ipaddresses
+        except AttributeError:
+            return "Not available"
+
+    def get_ipv6(self):
+        '''Get EthernetInterface ipv6 address
+ 
+        :returns:  list -- interface ip addresses or "Not available"
+ 
+        '''
+        
+        ipaddresses = []
+        
+        try:
+            for ip_settings in self.data.IPv6Addresses:
+                address = ip_settings['Address']
+                ipaddresses.append(address)
+            
+            return ipaddresses
+        except AttributeError:
+            return "Not available"