x/sqlalchemy-migrate
Code Issues Proposed changes

missed a postgres identifier quoting on renaming

Browse Source
This commit is contained in:
percious17 2008-11-27 00:17:55 +00:00
parent c7cbde7fea
commit e4382ab75b
2 changed files with 5 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
migrate/changeset/ansisql.py
View File

@ -29,8 +29,6 @@ class RawAlterTableVisitor(object):
def start_alter_table(self,param): def start_alter_table(self,param):
table = self._to_table(param) table = self._to_table(param)
table_name = self._to_table_name(table) table_name = self._to_table_name(table)
print '*'*80
print self
self.append('\nALTER TABLE %s ' % self._do_quote_table_identifier(table_name)) self.append('\nALTER TABLE %s ' % self._do_quote_table_identifier(table_name))
return table return table
@ -204,11 +202,11 @@ class ANSISchemaChanger(AlterTableVisitor,SchemaGenerator):
type_text = type.dialect_impl(self.dialect).get_col_spec() type_text = type.dialect_impl(self.dialect).get_col_spec()
self.start_alter_table(table_name) self.start_alter_table(table_name)
self.append("ALTER COLUMN %s TYPE %s"%(col_name,type_text)) self.append("ALTER COLUMN %s TYPE %s"%(col_name,type_text))
def _visit_column_name(self,table_name,col_name,delta): def _visit_column_name(self,table_name, col_name, delta):
new_name = delta['name'] new_name = delta['name']
self.start_alter_table(table_name) self.start_alter_table(table_name)
self.append('RENAME COLUMN %s TO %s'%(self._do_quote_column_identifier(col_name),new_name)) self.append('RENAME COLUMN %s TO %s'%(self._do_quote_column_identifier(col_name), self._do_quote_column_identifier(new_name)))
def visit_index(self,param): def visit_index(self,param):
"""Rename an index; #36""" """Rename an index; #36"""
index,newname = param index,newname = param

3
migrate/changeset/databases/postgres.py
View File

@ -9,7 +9,8 @@ class PGColumnGenerator(PGSchemaGenerator,ansisql.ANSIColumnGenerator):
return identifier return identifier
class PGColumnDropper(ansisql.ANSIColumnDropper): class PGColumnDropper(ansisql.ANSIColumnDropper):
pass def _do_quote_table_identifier(self, identifier):
return identifier
class PGSchemaChanger(ansisql.ANSISchemaChanger): class PGSchemaChanger(ansisql.ANSISchemaChanger):
def _do_quote_table_identifier(self, identifier): def _do_quote_table_identifier(self, identifier):