apply patch for issue #72 by asuffield@gmail.com

fixes #72
This commit is contained in:
asuffield@gmail.com 2012-01-23 21:34:12 +01:00
parent ddad9c7f8c
commit fe1f1deca8
2 changed files with 11 additions and 1 deletions

View File

@ -9,6 +9,7 @@ from migrate.exceptions import MigrateDeprecationWarning
from migrate.tests import fixture
from migrate.tests.fixture.warnings import catch_warnings
from migrate.versioning.util import *
from migrate.versioning import api
import warnings
@ -63,6 +64,15 @@ class TestUtil(fixture.Pathed):
# unsupported argument
self.assertRaises(ValueError, construct_engine, 1)
def test_passing_engine(self):
repo = self.tmp_repos()
api.create(repo, 'temp')
api.script('First Version', repo)
engine = construct_engine('sqlite:///:memory:')
api.version_control(engine, repo)
api.upgrade(engine, repo)
def test_asbool(self):
"""test asbool parsing"""
result = asbool(True)

View File

@ -158,7 +158,7 @@ def with_engine(f, *a, **kw):
kw['engine'] = engine
return f(*a, **kw)
finally:
if isinstance(engine, Engine):
if isinstance(engine, Engine) and engine is not url:
log.debug('Disposing SQLAlchemy engine %s', engine)
engine.dispose()