b7f19335f6
* Data updater is implemented * Completed implementation of commit processor * Logging is added into commit processor and runtime storage * Commit processor is fixed * Domain-company map is inverted * Extracted get update count into separate function * Fixed regex that matches diff statistics (lines inserted, lines deleted and files changed) * Implemented caching of unknown users * Replaced dictionaries by sets for pids and branches * Vcs is responsible for module and branches fields of commit record * Added release tags support * Implemented statistics by company * Added config for releases * Implemented front-end for companies details * Implemented front-end for modules details * Fixed metric switch * Implemented timeline rendering * Release selector is fixed * Chdir is needed after cloning a new repo * Company details screen is implemented * Fixed invalid emails processing by Launchpad * Fixed parsing of 0 files changed case * Module details screen implemented * Commit message is cleared and links are inserted * Engineer details screen is implemented * Fixed mapping from company to email for subdomains of 3rd level * Fixed wrong user structure for users not found by LP * Also coverage for commit processor * Fixed company matching algorithm * The company was not matched when user email had more domains than company's one * Add option to enforce sync with default data * Default data is added. Old confs removed * Add *.local into gitignore Scripts cleanup Moved from pylibmc to python-memcached Library pylibmc depends on libmemcached and doesn't work on CentOS (version conflict bw lib requirement and memcached). Change-Id: I0cc61c6d344ba24442ec954635010b518c0efa95
232 lines
8.5 KiB
Python
232 lines
8.5 KiB
Python
from launchpadlib import launchpad
|
|
import mock
|
|
from oslo.config import cfg
|
|
import testtools
|
|
|
|
from stackalytics.processor import commit_processor
|
|
from stackalytics.processor import persistent_storage
|
|
|
|
|
|
class TestCommitProcessor(testtools.TestCase):
|
|
def setUp(self):
|
|
super(TestCommitProcessor, self).setUp()
|
|
|
|
p_storage = mock.Mock(persistent_storage.PersistentStorage)
|
|
p_storage.get_companies = mock.Mock(return_value=[
|
|
{
|
|
'company_name': 'SuperCompany',
|
|
'domains': ['super.com', 'super.no']
|
|
},
|
|
{
|
|
"domains": ["nec.com", "nec.co.jp"],
|
|
"company_name": "NEC"
|
|
},
|
|
{
|
|
'company_name': '*independent',
|
|
'domains': ['']
|
|
},
|
|
])
|
|
self.user = {
|
|
'launchpad_id': 'john_doe', 'user_name': 'John Doe',
|
|
'emails': ['johndoe@gmail.com', 'jdoe@super.no'],
|
|
'companies': [
|
|
{'company_name': '*independent',
|
|
'end_date': 1234567890},
|
|
{'company_name': 'SuperCompany',
|
|
'end_date': 0},
|
|
]
|
|
}
|
|
p_storage.get_users = mock.Mock(return_value=[
|
|
self.user,
|
|
])
|
|
|
|
self.persistent_storage = p_storage
|
|
self.commit_processor = commit_processor.CachedProcessor(p_storage)
|
|
self.launchpad_patch = mock.patch('launchpadlib.launchpad.Launchpad')
|
|
self.launchpad_patch.start()
|
|
cfg.CONF = mock.MagicMock()
|
|
|
|
def tearDown(self):
|
|
super(TestCommitProcessor, self).tearDown()
|
|
self.launchpad_patch.stop()
|
|
|
|
def test_get_company_by_email_mapped(self):
|
|
email = 'jdoe@super.no'
|
|
res = self.commit_processor._get_company_by_email(email)
|
|
self.assertEquals('SuperCompany', res)
|
|
|
|
def test_get_company_by_email_with_long_suffix_mapped(self):
|
|
email = 'man@mxw.nes.nec.co.jp'
|
|
res = self.commit_processor._get_company_by_email(email)
|
|
self.assertEquals('NEC', res)
|
|
|
|
def test_get_company_by_email_with_long_suffix_mapped_2(self):
|
|
email = 'man@mxw.nes.nec.com'
|
|
res = self.commit_processor._get_company_by_email(email)
|
|
self.assertEquals('NEC', res)
|
|
|
|
def test_get_company_by_email_not_mapped(self):
|
|
email = 'foo@boo.com'
|
|
res = self.commit_processor._get_company_by_email(email)
|
|
self.assertEquals(None, res)
|
|
|
|
def test_update_commit_existing_user(self):
|
|
commit = {
|
|
'author_email': 'johndoe@gmail.com',
|
|
'date': 1999999999,
|
|
}
|
|
self.commit_processor._update_commit_with_user_data(commit)
|
|
|
|
self.assertEquals('SuperCompany', commit['company_name'])
|
|
self.assertEquals('john_doe', commit['launchpad_id'])
|
|
|
|
def test_update_commit_existing_user_old_job(self):
|
|
commit = {
|
|
'author_email': 'johndoe@gmail.com',
|
|
'date': 1000000000,
|
|
}
|
|
self.commit_processor._update_commit_with_user_data(commit)
|
|
|
|
self.assertEquals('*independent', commit['company_name'])
|
|
self.assertEquals('john_doe', commit['launchpad_id'])
|
|
|
|
def test_update_commit_existing_user_new_email_known_company(self):
|
|
"""
|
|
User is known to LP, his email is new to us, and maps to other company
|
|
Should return other company instead of those mentioned in user db
|
|
"""
|
|
email = 'johndoe@nec.co.jp'
|
|
commit = {
|
|
'author_email': email,
|
|
'date': 1999999999,
|
|
}
|
|
lp_mock = mock.MagicMock()
|
|
launchpad.Launchpad.login_anonymously = mock.Mock(return_value=lp_mock)
|
|
lp_profile = mock.Mock()
|
|
lp_profile.name = 'john_doe'
|
|
lp_mock.people.getByEmail = mock.Mock(return_value=lp_profile)
|
|
user = self.user.copy()
|
|
# tell storage to return existing user
|
|
self.persistent_storage.get_users.return_value = [user]
|
|
|
|
self.commit_processor._update_commit_with_user_data(commit)
|
|
|
|
self.persistent_storage.update_user.assert_called_once_with(user)
|
|
lp_mock.people.getByEmail.assert_called_once_with(email=email)
|
|
self.assertIn(email, user['emails'])
|
|
self.assertEquals('NEC', commit['company_name'])
|
|
self.assertEquals('john_doe', commit['launchpad_id'])
|
|
|
|
def test_update_commit_existing_user_new_email_unknown_company(self):
|
|
"""
|
|
User is known to LP, but his email is new to us. Should match
|
|
the user and return current company
|
|
"""
|
|
email = 'johndoe@yahoo.com'
|
|
commit = {
|
|
'author_email': email,
|
|
'date': 1999999999,
|
|
}
|
|
lp_mock = mock.MagicMock()
|
|
launchpad.Launchpad.login_anonymously = mock.Mock(return_value=lp_mock)
|
|
lp_profile = mock.Mock()
|
|
lp_profile.name = 'john_doe'
|
|
lp_mock.people.getByEmail = mock.Mock(return_value=lp_profile)
|
|
user = self.user.copy()
|
|
# tell storage to return existing user
|
|
self.persistent_storage.get_users.return_value = [user]
|
|
|
|
self.commit_processor._update_commit_with_user_data(commit)
|
|
|
|
self.persistent_storage.update_user.assert_called_once_with(user)
|
|
lp_mock.people.getByEmail.assert_called_once_with(email=email)
|
|
self.assertIn(email, user['emails'])
|
|
self.assertEquals('SuperCompany', commit['company_name'])
|
|
self.assertEquals('john_doe', commit['launchpad_id'])
|
|
|
|
def test_update_commit_new_user(self):
|
|
"""
|
|
User is known to LP, but new to us
|
|
Should add new user and set company depending on email
|
|
"""
|
|
email = 'smith@nec.com'
|
|
commit = {
|
|
'author_email': email,
|
|
'date': 1999999999,
|
|
}
|
|
lp_mock = mock.MagicMock()
|
|
launchpad.Launchpad.login_anonymously = mock.Mock(return_value=lp_mock)
|
|
lp_profile = mock.Mock()
|
|
lp_profile.name = 'smith'
|
|
lp_profile.display_name = 'Smith'
|
|
lp_mock.people.getByEmail = mock.Mock(return_value=lp_profile)
|
|
self.persistent_storage.get_users.return_value = []
|
|
|
|
self.commit_processor._update_commit_with_user_data(commit)
|
|
|
|
lp_mock.people.getByEmail.assert_called_once_with(email=email)
|
|
self.assertEquals('NEC', commit['company_name'])
|
|
self.assertEquals('smith', commit['launchpad_id'])
|
|
|
|
def test_update_commit_new_user_unknown_to_lb(self):
|
|
"""
|
|
User is new to us and not known to LP
|
|
Should set user name and empty LPid
|
|
"""
|
|
email = 'inkognito@avs.com'
|
|
commit = {
|
|
'author_email': email,
|
|
'date': 1999999999,
|
|
}
|
|
lp_mock = mock.MagicMock()
|
|
launchpad.Launchpad.login_anonymously = mock.Mock(return_value=lp_mock)
|
|
lp_mock.people.getByEmail = mock.Mock(return_value=None)
|
|
self.persistent_storage.get_users.return_value = []
|
|
|
|
self.commit_processor._update_commit_with_user_data(commit)
|
|
|
|
lp_mock.people.getByEmail.assert_called_once_with(email=email)
|
|
self.assertEquals('*independent', commit['company_name'])
|
|
self.assertEquals(None, commit['launchpad_id'])
|
|
|
|
def test_update_commit_new_user_lb_raises_error(self):
|
|
"""
|
|
LP raises error during getting user info
|
|
"""
|
|
email = 'smith@avs.com'
|
|
commit = {
|
|
'author_email': email,
|
|
'date': 1999999999,
|
|
}
|
|
lp_mock = mock.MagicMock()
|
|
launchpad.Launchpad.login_anonymously = mock.Mock(return_value=lp_mock)
|
|
lp_mock.people.getByEmail = mock.Mock(return_value=None,
|
|
side_effect=Exception)
|
|
self.persistent_storage.get_users.return_value = []
|
|
|
|
self.commit_processor._update_commit_with_user_data(commit)
|
|
|
|
lp_mock.people.getByEmail.assert_called_once_with(email=email)
|
|
self.assertEquals('*independent', commit['company_name'])
|
|
self.assertEquals(None, commit['launchpad_id'])
|
|
|
|
def test_update_commit_invalid_email(self):
|
|
"""
|
|
User's email is malformed
|
|
"""
|
|
email = 'error.root'
|
|
commit = {
|
|
'author_email': email,
|
|
'date': 1999999999,
|
|
}
|
|
lp_mock = mock.MagicMock()
|
|
launchpad.Launchpad.login_anonymously = mock.Mock(return_value=lp_mock)
|
|
lp_mock.people.getByEmail = mock.Mock(return_value=None)
|
|
self.persistent_storage.get_users.return_value = []
|
|
|
|
self.commit_processor._update_commit_with_user_data(commit)
|
|
|
|
self.assertEquals(0, lp_mock.people.getByEmail.called)
|
|
self.assertEquals('*independent', commit['company_name'])
|
|
self.assertEquals(None, commit['launchpad_id'])
|