x/tuskar-ui
Code Issues Proposed changes

Remove template comments from compressed blocks.

Browse Source 
Template comment tags within compressed blocks throws off
checksum calculation with older versions of compressor. This
makes offline compression impossible and requires the pages
be rendered for every request with online compression.

Removing trivial comments from the compressed blocks ensures Horizon
is compatable with older versions (v1.1.2 shipping with Ubuntu).

Change-Id: I3a9f2614695b72445719101bfa2480384d77f3a4
This commit is contained in:
Adam Gandelman 2012-09-11 11:25:55 -07:00
parent 3b69c6adc8
commit a8c92dc271
1 changed files with 1 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
horizon/templates/horizon/_scripts.html
View File

@ -3,8 +3,8 @@
{% comment %} Django's JavaScript i18n Implementation {% endcomment %}
<script type="text/javascript" src="{% url horizon:jsi18n 'horizon' %}"></script>
{% comment %} Compress jQuery, Plugins, Bootstrap, Hogan.js and Horizon-specific JS. {% endcomment %}
{% compress js %}
{% comment %} jQuery and Plugins {% endcomment %}
<script src='{{ STATIC_URL }}horizon/lib/jquery/jquery.min.js' type='text/javascript' charset="utf-8"></script>
<script src='{{ STATIC_URL }}horizon/lib/jquery/jquery.cookie.js' type='text/javascript' charset="utf-8"></script>
<script src='{{ STATIC_URL }}horizon/lib/jquery/jquery.quicksearch.js' type='text/javascript' charset="utf-8"></script>
@ -14,13 +14,10 @@
<script src='{{ STATIC_URL }}horizon/lib/json2.js' type='text/javascript' charset="utf-8"></script>
<script src="{{ STATIC_URL }}horizon/lib/underscore/underscore-min.js" type="text/javascript" charset="utf-8"></script>
{% comment %} Bootstrap {% endcomment %}
<script src="{{ STATIC_URL }}bootstrap/js/bootstrap.min.js" type="text/javascript" charset="utf-8"></script>
{% comment %} Hogan.js (client-side templating) {% endcomment %}
<script src="{{ STATIC_URL }}horizon/lib/hogan-1.0.5.min.js" type="text/javascript" charset='utf-8'></script>
{% comment %} Horizon-specific JS {% endcomment %}
<script src='{{ STATIC_URL }}horizon/js/horizon.communication.js' type='text/javascript' charset='utf-8'></script>
<script src='{{ STATIC_URL }}horizon/js/horizon.cookies.js' type='text/javascript' charset='utf-8'></script>
<script src='{{ STATIC_URL }}horizon/js/horizon.forms.js' type='text/javascript' charset='utf-8'></script>