From e5dd94576129f7472e909bfbdf90f62063db3d30 Mon Sep 17 00:00:00 2001 From: Maohaijun Date: Wed, 4 Jan 2017 10:15:15 +0800 Subject: [PATCH] There is no '_' module in valence If want to use '_' module, it should import module i18n and fix internationalizeation issue in project valence Change-Id: Ic8b9bc3aee59cdc6760d602ee210478c180ac031 --- valence/api/types.py | 4 ++-- valence/tests/unit/api/test_types.py | 5 +++-- 2 files changed, 5 insertions(+), 4 deletions(-) diff --git a/valence/api/types.py b/valence/api/types.py index 5b859bd..c1d7206 100644 --- a/valence/api/types.py +++ b/valence/api/types.py @@ -69,8 +69,8 @@ class Integer(object): raise ValueError("Failed to convert value to int") if minimum is not None and value < minimum: - message = _("Integer '%(value)s' is smaller than " - "'%(min)d'.") % {'value': value, 'min': minimum} + message = ("Integer '%(value)s' is smaller than" + " '%(min)d'.") % {'value': value, 'min': minimum} raise ValueError(message) return value diff --git a/valence/tests/unit/api/test_types.py b/valence/tests/unit/api/test_types.py index c8439cd..27875e2 100644 --- a/valence/tests/unit/api/test_types.py +++ b/valence/tests/unit/api/test_types.py @@ -67,8 +67,9 @@ class TestTypes(TestCase): test_value, minimum=9)) self.assertEqual(test_value, types.Integer.validate( test_value, minimum=10)) - # self.assertRaises(test_value, types.Integer.validate( - # test_value, minimum=11)) + self.assertRaises(ValueError, + types.Integer.validate, test_value, + minimum=11) def test_bool_type(self): self.assertTrue(types.Bool.validate(None, default=True))