x/valence
Code Issues Proposed changes

There is no '_' module in valence

Browse Source 
If want to use '_' module, it should import module i18n
and fix internationalizeation issue in project valence

Change-Id: Ic8b9bc3aee59cdc6760d602ee210478c180ac031
This commit is contained in:
Maohaijun 2017-01-04 10:15:15 +08:00
parent 4ed27a85d7
commit e5dd945761
2 changed files with 5 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
valence/api/types.py
View File

@ -69,8 +69,8 @@ class Integer(object):
raise ValueError("Failed to convert value to int") raise ValueError("Failed to convert value to int")
if minimum is not None and value < minimum: if minimum is not None and value < minimum:
message = _("Integer '%(value)s' is smaller than " message = ("Integer '%(value)s' is smaller than"
"'%(min)d'.") % {'value': value, 'min': minimum} " '%(min)d'.") % {'value': value, 'min': minimum}
raise ValueError(message) raise ValueError(message)
return value return value

5
valence/tests/unit/api/test_types.py
View File

@ -67,8 +67,9 @@ class TestTypes(TestCase):
test_value, minimum=9)) test_value, minimum=9))
self.assertEqual(test_value, types.Integer.validate( self.assertEqual(test_value, types.Integer.validate(
test_value, minimum=10)) test_value, minimum=10))
# self.assertRaises(test_value, types.Integer.validate( self.assertRaises(ValueError,
# test_value, minimum=11)) types.Integer.validate, test_value,
minimum=11)
def test_bool_type(self): def test_bool_type(self):
self.assertTrue(types.Bool.validate(None, default=True)) self.assertTrue(types.Bool.validate(None, default=True))