x/vmware-nsx
Code Issues Proposed changes

NSX|V: don't log eception when edge is not active

Browse Source 
There is no need to log the exception trace when an edge is down or in
error state. A log error is sufficient.

Change-Id: Icf06db06f3f3e02f01917d543d269b3b4c317aa9
This commit is contained in:
Gary Kotton 2016-06-30 01:48:35 -07:00
parent 30a4cf2d5f
commit cc0609b5b4
1 changed files with 4 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
vmware_nsx/plugins/nsx_v/vshield/edge_appliance_driver.py
View File

@ -223,8 +223,9 @@ class EdgeApplianceDriver(object):
status_level = self._edge_status_to_level( status_level = self._edge_status_to_level(
response['edgeStatus']) response['edgeStatus'])
except exceptions.VcnsApiException as e: except exceptions.VcnsApiException as e:
LOG.exception(_LE("VCNS: Failed to get edge status:\n%s"), LOG.error(_LE("VCNS: Failed to get edge %(edge_id)s status: "
e.response) "Reason: %(reason)s"),
{'edge_id': edge_id, 'reason': e.response})
status_level = constants.RouterStatus.ROUTER_STATUS_ERROR status_level = constants.RouterStatus.ROUTER_STATUS_ERROR
try: try:
desc = jsonutils.loads(e.response) desc = jsonutils.loads(e.response)
@ -232,7 +233,7 @@ class EdgeApplianceDriver(object):
constants.VCNS_ERROR_CODE_EDGE_NOT_RUNNING): constants.VCNS_ERROR_CODE_EDGE_NOT_RUNNING):
status_level = constants.RouterStatus.ROUTER_STATUS_DOWN status_level = constants.RouterStatus.ROUTER_STATUS_DOWN
except ValueError: except ValueError:
LOG.exception(e.response) LOG.error(_LE('Error code not present. %s'), e.response)
return status_level return status_level