x/vmware-nsxlib
Code Issues Proposed changes

NSXT: Add rule tag support

Browse Source 
Expose firewall rule rule_tag property.

Change-Id: Iec6848e325bb7e1eb43b83d060ba9486897cc93a
This commit is contained in:
Shih-Hao Li 2020-08-24 03:28:43 -07:00
parent 8724fe16ad
commit 3ba085fec3
2 changed files with 24 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

20
vmware_nsxlib/tests/unit/v3/test_security.py
View File

@ -62,6 +62,26 @@ class TestNsxLibFirewallSection(nsxlib_testcase.NsxLibTestCase):
} }
self.assertEqual(expected, result) self.assertEqual(expected, result)
def test_get_rule_dict(self):
result = self.nsxlib.firewall_section.get_rule_dict(
'display_name', sources='sources', destinations='destinations',
direction=const.IN_OUT, ip_protocol=const.IPV4_IPV6,
services='services', action=const.FW_ACTION_ALLOW,
logged=True, disabled=True, applied_tos='applied_tos',
rule_tag='rule_tag')
expected = {'display_name': 'display_name',
'sources': 'sources',
'destinations': 'destinations',
'direction': const.IN_OUT,
'ip_protocol': const.IPV4_IPV6,
'services': 'services',
'action': const.FW_ACTION_ALLOW,
'logged': True,
'disabled': True,
'applied_tos': 'applied_tos',
'rule_tag': 'rule_tag'}
self.assertEqual(expected, result)
def test_create_rules_with_protocol(self): def test_create_rules_with_protocol(self):
with mock.patch("vmware_nsxlib.v3.security.NsxLibFirewallSection" with mock.patch("vmware_nsxlib.v3.security.NsxLibFirewallSection"
".add_rules") as add_rules: ".add_rules") as add_rules:

5
vmware_nsxlib/v3/security.py
View File

@ -407,7 +407,8 @@ class NsxLibFirewallSection(utils.NsxLibApiBase):
def get_rule_dict(self, display_name, sources=None, destinations=None, def get_rule_dict(self, display_name, sources=None, destinations=None,
direction=consts.IN_OUT, ip_protocol=consts.IPV4_IPV6, direction=consts.IN_OUT, ip_protocol=consts.IPV4_IPV6,
services=None, action=consts.FW_ACTION_ALLOW, services=None, action=consts.FW_ACTION_ALLOW,
logged=False, disabled=False, applied_tos=None): logged=False, disabled=False, applied_tos=None,
rule_tag=None):
rule_dict = {'display_name': display_name, rule_dict = {'display_name': display_name,
'direction': direction, 'direction': direction,
'ip_protocol': ip_protocol, 'ip_protocol': ip_protocol,
@ -419,6 +420,8 @@ class NsxLibFirewallSection(utils.NsxLibApiBase):
'services': services or []} 'services': services or []}
if applied_tos is not None: if applied_tos is not None:
rule_dict['applied_tos'] = applied_tos rule_dict['applied_tos'] = applied_tos
if rule_tag is not None:
rule_dict['rule_tag'] = rule_tag
return rule_dict return rule_dict
def add_rule(self, rule, section_id, operation=consts.FW_INSERT_BOTTOM): def add_rule(self, rule, section_id, operation=consts.FW_INSERT_BOTTOM):