zuul/zuul-jobs
Code Issues Proposed changes

explicit error when test_command is undef

Browse Source 
Don't use a shell builtin: shell builtins aren't available since
'command' ansible module is used. Instead, fail with an explicit
error when the required test_command variable is not set.

Fix this error:

    Ansible output: b'failed: [host] (item=exit 1) => {
        "ansible_loop_var": "item",
        "changed": false,
        "cmd": "exit 1",
        "item": "exit 1",
        "msg": "[Errno 2] No such file or directory: 'exit': 'exit'",
        "rc": 2
    }

Change-Id: I88303f7302d7354ffc8b18e607b28349a9860a57
This commit is contained in:
Pierre-Louis Bonicoli 2020-09-14 09:48:25 +02:00
parent ca4111a586
commit 0eb09e7b4f
No known key found for this signature in database
GPG Key ID: 06914C4A5EDAA6DD
2 changed files with 5 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
playbooks/run-test-command/run.yaml
View File

@ -1,6 +1,11 @@
- hosts: all - hosts: all
tasks: tasks:
- name: Abort when test_command variable is undefined
fail:
msg: mandatory test_command variable is undefined
when: test_command is undefined
- name: Convert test_command to list - name: Convert test_command to list
set_fact: set_fact:
test_commands: ['{{ test_command }}'] test_commands: ['{{ test_command }}']

2
zuul.d/general-jobs.yaml
View File

@ -40,8 +40,6 @@
Path to operate in. Path to operate in.
run: playbooks/run-test-command/run.yaml run: playbooks/run-test-command/run.yaml
vars:
test_command: "exit 1"
- job: - job:
name: upload-git-mirror name: upload-git-mirror