zuul/zuul-jobs
Code Issues Proposed changes

Fix upload-docker-image when in release pipeline

Browse Source 
The zuul.change variable isn't defined when run in a tag-based
release pipeline.  Even though it's wrapped in a ternary operator,
it is still dereferenced even if it's not used.  Make sure we
dereference it safely.

Change-Id: I215a003493603de99296035d77eee64cc66e83f1
This commit is contained in:
James E. Blair 2020-06-12 13:57:09 -07:00
parent c713ed7a55
commit d46b41857c
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
roles/upload-docker-image/tasks/push.yaml
View File

@ -1,5 +1,5 @@
- name: Upload tag to dockerhub
command: "docker push {{ zj_image.repository }}:{{ upload_docker_image_promote | ternary('change_' + zuul.change + '_', '') }}{{ zj_image_tag }}"
command: "docker push {{ zj_image.repository }}:{{ upload_docker_image_promote | ternary('change_' + zuul.get('change', '') + '_', '') }}{{ zj_image_tag }}"
loop: "{{ zj_image.tags | default(['latest']) }}"
loop_control:
loop_var: zj_image_tag