From d46b41857ce1b0afa1930c115a9b0486750b4d00 Mon Sep 17 00:00:00 2001 From: "James E. Blair" Date: Fri, 12 Jun 2020 13:57:09 -0700 Subject: [PATCH] Fix upload-docker-image when in release pipeline The zuul.change variable isn't defined when run in a tag-based release pipeline. Even though it's wrapped in a ternary operator, it is still dereferenced even if it's not used. Make sure we dereference it safely. Change-Id: I215a003493603de99296035d77eee64cc66e83f1 --- roles/upload-docker-image/tasks/push.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/roles/upload-docker-image/tasks/push.yaml b/roles/upload-docker-image/tasks/push.yaml index dac3b45e1..b6c8fccff 100644 --- a/roles/upload-docker-image/tasks/push.yaml +++ b/roles/upload-docker-image/tasks/push.yaml @@ -1,5 +1,5 @@ - name: Upload tag to dockerhub - command: "docker push {{ zj_image.repository }}:{{ upload_docker_image_promote | ternary('change_' + zuul.change + '_', '') }}{{ zj_image_tag }}" + command: "docker push {{ zj_image.repository }}:{{ upload_docker_image_promote | ternary('change_' + zuul.get('change', '') + '_', '') }}{{ zj_image_tag }}" loop: "{{ zj_image.tags | default(['latest']) }}" loop_control: loop_var: zj_image_tag