zuul/zuul-jobs
Code Issues Proposed changes

upload-git-mirror: check after mirror operation

Browse Source 
The upload-git-mirror job currently reports failure when multiple
jobs run concurrently for the same repository (one of them succeeds,
the other fails because the state of the mirror was changed by the
successful one).

However, since the job generally runs a few minutes after the commit
that triggered it merged, the successful job usually mirrored the two
needed commits, so the failed mirror operation does not mean the
mirror is out-of-sync. This results in false negatives.

If zuul.newrev is provided, rather than report failure if the mirror
operation fails, we should report failure if, after the mirror operation,
the commit that triggered the job is still not present on the mirror.

Change-Id: Iadae26473f4c937384c8cea74329e389c563aeed
This commit is contained in:
Thierry Carrez 2020-06-23 14:49:37 +02:00
parent 849757dbb1
commit e53fe850c8
1 changed files with 10 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
roles/upload-git-mirror/tasks/main.yaml
View File

@ -38,6 +38,16 @@
chdir: "{{ ansible_user_dir }}/{{ zuul.project.src_dir }}"
tags:
- skip_ansible_lint
ignore_errors: zuul.newrev is defined
- name: Check if the mirror contains the desired reference
command: git fetch {{ git_mirror_credentials.user }}@{{ git_mirror_credentials.host }}:{{ git_mirror_repository }} {{ zuul.newrev }}
args:
chdir: "{{ ansible_user_dir }}/{{ zuul.project.src_dir }}"
tags:
- skip_ansible_lint
when: zuul.newrev is defined
always:
# Registered variables below are only used for integration testing
- name: Remove SSH private key from disk