zuul/zuul-jobs
Code Issues Proposed changes

Remove download_artifact_name parameter

Browse Source 
This parameter was deprecated.  Now it should be removed so that
the name field can be freed up to be a human-readable name.

Change-Id: I0ace733e037ebeffcaf516332e7c5b48b3c7a1a3
This commit is contained in:
James E. Blair 2019-07-29 09:05:20 -07:00
parent 634fa42920
commit ed0c36250c
2 changed files with 1 additions and 20 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
roles/download-artifact/README.rst
View File

@ -18,13 +18,6 @@ many artifacts as match the selection criteria.
The job of the previous build. The job of the previous build.
.. zuul:rolevar:: download_artifact_name
.. warning:: This field is deprecated and will be removed. Use
``download_artifact_type`` instead.
The artifact name. This can be a string or a list of strings.
.. zuul:rolevar:: download_artifact_type .. zuul:rolevar:: download_artifact_type
The artifact type. This is the value of the ``type`` field in the The artifact type. This is the value of the ``type`` field in the

14
roles/download-artifact/tasks/main.yaml
View File

@ -5,16 +5,6 @@
- name: Parse build response - name: Parse build response
set_fact: set_fact:
build: "{{ build.json[0] }}" build: "{{ build.json[0] }}"
- name: Download archive by name
uri:
url: "{{ artifact.url }}"
dest: "{{ download_artifact_directory }}"
loop: "{{ build.artifacts }}"
loop_control:
loop_var: artifact
when:
- "download_artifact_name is defined"
- "artifact.name == download_artifact_name or ((download_artifact_name | type_debug) == 'list' and artifact.name in download_artifact_name)"
- name: Download archive by type - name: Download archive by type
uri: uri:
url: "{{ artifact.url }}" url: "{{ artifact.url }}"
@ -22,6 +12,4 @@
loop: "{{ build.artifacts }}" loop: "{{ build.artifacts }}"
loop_control: loop_control:
loop_var: artifact loop_var: artifact
when: when: "'metadata' in artifact and 'type' in artifact.metadata and (artifact.metadata.type == download_artifact_type or ((download_artifact_type | type_debug) == 'list' and artifact.metadata.type in download_artifact_type))"
- "download_artifact_type is defined"
- "'metadata' in artifact and 'type' in artifact.metadata and (artifact.metadata.type == download_artifact_type or ((download_artifact_type | type_debug) == 'list' and artifact.metadata.type in download_artifact_type))"